Add solution to project_euler/problem_060 #8678

ignacio-gn · 2023-04-22T10:23:06Z

Describe your change:

Add a solution to problem 60 of project Euler

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-04-22T14:29:56Z

project_euler/problem_060/sol1.py

+COUNTER = False
+
+
+def get_order(n: int) -> int:


Please provide descriptive name for the parameter: n

algorithms-keeper · 2023-04-22T14:29:56Z

project_euler/problem_060/sol1.py

+    return True
+
+
+def is_prime(n) -> bool:


Please provide descriptive name for the parameter: n

Please provide type hint for the parameter: n

rohan472000 · 2023-04-22T14:55:51Z

@ignacio-gn use ruff . before making PR, if fix needed then use ruff . --fix ,so that it will automatically fix it.

ignacio-gn · 2023-04-22T15:00:45Z

@ignacio-gn use ruff . before making PR, if fix needed then use ruff . --fix ,so that it will automatically fix it.

I noticed that ruff fails for files that were already present in the repository, which I did not edit. Because of that, I decided to leave these files intact. I can attempt to fix them or rebase once they are fixed. Below is the error message:

Error: ciphers/rsa_cipher.py:79:13: UP031 Use format specifiers instead of percent format
[5](https://github.com/TheAlgorithms/Python/actions/runs/4773277000/jobs/8486249952?pr=8678#step:4:6)
Error: ciphers/rsa_cipher.py:104:13: UP031 Use format specifiers instead of percent format
[6](https://github.com/TheAlgorithms/Python/actions/runs/4773277000/jobs/8486249952?pr=8678#step:4:7)
Error: machine_learning/linear_discriminant_analysis.py:402:16: S605 Starting a process with a shell, possible injection detected
[7](https://github.com/TheAlgorithms/Python/actions/runs/4773277000/jobs/8486249952?pr=8678#step:4:8)
Error: Process completed with exit code 1.

rohan472000 · 2023-04-22T15:12:23Z

The first two errors suggest that we should use format specifiers instead of percent format. So we'll need to update the code in ciphers/rsa_cipher.pyon lines 79 and 104 to use format specifiers. For example, instead of using %d, we would use {} and then use .format() to fill in the value.

The third error suggests that there may be a possible injection detected. we should check the code in machine_learning/linear_discriminant_analysis.py on line 402 and ensure that any commands being executed are properly sanitized and do not pose any security risks.

Once we have made the necessary changes, you can run ruff . --fix to automatically fix any remaining issues. After that, you can rebase your changes and submit your updated pull request for review.

rohan472000 · 2023-04-22T15:38:57Z

@ignacio-gn I have made PR #8680 and #8679 to address above issue for both files, can you merge that two PR in one, rohan472000:patch-8 into rohan472000:patch-9 because I cant see both branches in my local after fork.

for more information, see https://pre-commit.ci

rohan472000 · 2023-04-22T18:12:20Z

I have merged both PR into one #8680

…criminant_analysis.py

rohan472000 · 2023-04-23T18:03:47Z

commenting out that line 402 is working for now, which is good, but what alternative can we put there instead of that line???

ignacio-gn · 2023-04-23T18:53:49Z

I have commented out the system call to clear the console on machine_learning/linear_discriminant_analysis.py. The reason for this is that I don't consider it to be relevant enough in the context of the program to implement an alternative that does not pose a security risk. The original call was there to clear the console on a new iteration of the program, but that behavior is not essential and it's blocking other PRs too (see 8684 and 8674).

I haven't contributed to machine_learning/linear_discriminant_analysis.py so I'd understand if you want to find another solution and to discard this one. In that case, let me know and I'll rollback the changes.

rohan472000

as #8680 is merged so there is no need to make any changes in those files, just run github actions again , it should work fine.

…ms#8680) * Update rsa_cipher.py by replacing %s with {} * Update rsa_cipher.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update linear_discriminant_analysis.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update linear_discriminant_analysis.py * Update linear_discriminant_analysis.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update linear_discriminant_analysis.py * Update linear_discriminant_analysis.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update linear_discriminant_analysis.py * Update machine_learning/linear_discriminant_analysis.py Co-authored-by: Christian Clauss <[email protected]> * Update linear_discriminant_analysis.py * updated --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <[email protected]>

for more information, see https://pre-commit.ci

Add solution to project_euler/problem_060

2df4a7e

ignacio-gn requested a review from dhruvmanila as a code owner April 22, 2023 10:23

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Apr 22, 2023

ignacio-gn added 2 commits April 22, 2023 16:25

Reword algorith explanation on project_euler/problem_060

8ccffdf

Disable timer on project_euler/problem_060/sol1.py

6335937

algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require type hints https://docs.python.org/3/library/typing.html labels Apr 22, 2023

algorithms-keeper bot reviewed Apr 22, 2023

View reviewed changes

algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Apr 22, 2023

Implement suggested formatting for project_euler/problem_060/sol1.py

8ab9745

algorithms-keeper bot removed require descriptive names This PR needs descriptive function and/or variable names require type hints https://docs.python.org/3/library/typing.html labels Apr 22, 2023

rohan472000 and others added 6 commits April 22, 2023 17:50

Update linear_discriminant_analysis.py

2faf2e9

[pre-commit.ci] auto fixes from pre-commit.com hooks

bff2edf

for more information, see https://pre-commit.ci

Update linear_discriminant_analysis.py

41220e7

Update rsa_cipher.py by replacing %s with {}

de13a9a

Update rsa_cipher.py

d91fc28

[pre-commit.ci] auto fixes from pre-commit.com hooks

69015fb

for more information, see https://pre-commit.ci

rohan472000 mentioned this pull request Apr 22, 2023

Update linear_discriminant_analysis.py and rsa_cipher.py #8680

Merged

14 tasks

Remove system command to clear console on machine_learning/linear_dis…

24a73e7

…criminant_analysis.py

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Apr 23, 2023

rohan472000 suggested changes Apr 24, 2023

View reviewed changes

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Apr 24, 2023

ignacio-gn and others added 4 commits April 24, 2023 09:38

Merge branch 'TheAlgorithms:master' into master

5b25aed

Update rsa_cipher.py

2962391

[pre-commit.ci] auto fixes from pre-commit.com hooks

c596016

for more information, see https://pre-commit.ci

Rollback changes

1908694

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Apr 24, 2023

CaedenPH mentioned this pull request Aug 18, 2023

What to do about project euler solution pull requests #8990

Open

cclauss closed this Sep 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add solution to project_euler/problem_060 #8678

Add solution to project_euler/problem_060 #8678

ignacio-gn commented Apr 22, 2023

algorithms-keeper bot left a comment

algorithms-keeper bot Apr 22, 2023

algorithms-keeper bot Apr 22, 2023

rohan472000 commented Apr 22, 2023

ignacio-gn commented Apr 22, 2023

rohan472000 commented Apr 22, 2023 •

edited

Loading

rohan472000 commented Apr 22, 2023 •

edited

Loading

rohan472000 commented Apr 22, 2023

rohan472000 commented Apr 23, 2023

ignacio-gn commented Apr 23, 2023

rohan472000 left a comment

Add solution to project_euler/problem_060 #8678

Add solution to project_euler/problem_060 #8678

Conversation

ignacio-gn commented Apr 22, 2023

Describe your change:

Checklist:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Apr 22, 2023

Choose a reason for hiding this comment

algorithms-keeper bot Apr 22, 2023

Choose a reason for hiding this comment

rohan472000 commented Apr 22, 2023

ignacio-gn commented Apr 22, 2023

rohan472000 commented Apr 22, 2023 • edited Loading

rohan472000 commented Apr 22, 2023 • edited Loading

rohan472000 commented Apr 22, 2023

rohan472000 commented Apr 23, 2023

ignacio-gn commented Apr 23, 2023

rohan472000 left a comment

Choose a reason for hiding this comment

rohan472000 commented Apr 22, 2023 •

edited

Loading

rohan472000 commented Apr 22, 2023 •

edited

Loading